Skip to content

feat: added isNumber expression type operator #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwaldvogel merged 1 commit into from
Oct 1, 2025
Merged

feat: added isNumber expression type operator #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions core/src/main/java/de/bwaldvogel/mongo/backend/aggregation/Expression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import de.bwaldvogel.mongo.backend.NumericUtils;
import de.bwaldvogel.mongo.backend.Utils;
import de.bwaldvogel.mongo.backend.ValueComparator;
import de.bwaldvogel.mongo.bson.Decimal128;
import de.bwaldvogel.mongo.bson.Document;
import de.bwaldvogel.mongo.bson.ObjectId;
import de.bwaldvogel.mongo.exception.BadValueException;
Expand Down Expand Up @@ -772,6 +773,17 @@ Object apply(List<?> expressionValue, Document document) {
}
},

$isNumber {
@Override
Boolean apply(List<?> expressionValue, Document document) {
Object value = requireSingleValue(expressionValue);
return (value instanceof Integer ||
value instanceof Decimal128 ||
value instanceof Double ||
value instanceof Long);
}
},

$literal {
@Override
Object apply(Object expressionValue, Document document) {
Expand Down
12 changes: 12 additions & 0 deletions core/src/test/java/de/bwaldvogel/mongo/backend/aggregation/ExpressionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1781,6 +1781,18 @@ void testEvaluateIsArray() throws Exception {
.withMessage("[Error 16020] Expression $isArray takes exactly 1 arguments. 2 were passed in.");
}

@Test
void testEvaluateIsNumber() throws Exception {
assertThat(Expression.evaluate(json("$isNumber: ['hello']"), json(""))).isEqualTo(false);
assertThat(Expression.evaluate(json("$isNumber: 'pi'}"), json(""))).isEqualTo(false);
assertThat(Expression.evaluate(json("$isNumber: null"), json(""))).isEqualTo(false);
assertThat(Expression.evaluate(json("$isNumber: '$value'"), json("value: 'a'"))).isEqualTo(false);
assertThat(Expression.evaluate(json("$isNumber: '$value'"), json("value: ['abc']"))).isEqualTo(false);
assertThat(Expression.evaluate(json("$isNumber: '$value'"), json("value: 1"))).isEqualTo(true);
assertThat(Expression.evaluate(json("$isNumber: '$value'"), json("value: 2.0"))).isEqualTo(true);
assertThat(Expression.evaluate(json("$isNumber: '$value'"), json("value: 3.141592653589793"))).isEqualTo(true);
}

@Test
void testEvaluateLiteral() throws Exception {
assertThat(Expression.evaluate(json("$literal: {$add: [2, 3]}"), json(""))).isEqualTo(json("$add: [2, 3]"));
Expand Down