Skip to content

Missing parser tests #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tristanlatr wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Missing parser tests #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7224c63
Add dependencies to the tox environment
tristanlatr May 26, 2025
c5f05da
Add bunch of test cases that ARE running within the pydoctor test suite.
tristanlatr May 26, 2025
5c2d6ee
Merge branch 'master' into 313-missing-parser-tests
tristanlatr May 26, 2025
9b27c57
Sort out the test dependencies.
tristanlatr May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def launch_http_server(directory):
"mock",
"PyYAML",
"pytest",
"toml",
Copy link
Contributor

@kingbuzzman kingbuzzman Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont use this.

Use standard library equivalent tomli -- this is what py3.11+ is called tomlib.

Might i suggest you merge my #316 and #317 first?

Copy link
Collaborator Author

@tristanlatr tristanlatr Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want these config parses tests to run on Python versions below 3.11 we must install it on the testing environment. Please note that it stays a loose requirement to install ConfigArgParse. This is just the tests’ requirements.

Copy link
Contributor

@kingbuzzman kingbuzzman Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tomli is compatible with 3.6, pip just finds the appropriate version and installs it. Example

Copy link
Contributor

@kingbuzzman kingbuzzman Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my tests are working with it right now over at #317

Copy link
Collaborator Author

@tristanlatr tristanlatr Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I understand. Did not saw the subtle change of requirement from toml to tomli

Copy link
Contributor

@kingbuzzman kingbuzzman Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

]


Expand Down
Loading
Loading