Skip to content

Conversation

@benjamin-fenker
Copy link

Resolves #265

@tbooth
Copy link
Collaborator

tbooth commented Apr 14, 2025

I see what this PR is getting at but I feel like it might not work in all cases. I think we definitely need some extra tests before accepting this change.

Also, some nitpicks:

  • Avoid using a list comprehension for side effects. The first one is fine, but the second should be an actual for loop
  • The comments in the code should be changed in line with the code changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Positional config file arguments do not work when config file arg is not first

2 participants