Accept frontend field names (payee, account, imported_payee) in rules#215
Open
DAdjadj wants to merge 2 commits into
Open
Accept frontend field names (payee, account, imported_payee) in rules#215DAdjadj wants to merge 2 commits into
DAdjadj wants to merge 2 commits into
Conversation
…conditions and actions The Actual frontend stores rules with app-level field names, while the models only accepted the internal column names. A budget containing a rule that conditions on payee or account failed validation on load. Closes bvanelli#211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211
The Actual frontend stores rule conditions and actions using app-level field names (
payee,account,imported_payee), while the models only accepted the internal column names (description,acct,imported_description). Any budget containing a rule that conditions on payee or account failed validation onget_ruleset(), which in turn maderun_rules()unusable for that budget.This adds a
BeforeValidatorthat maps the frontend names to their internal counterparts on bothCondition.fieldandAction.field, plus a test loading conditions/actions exactly as the frontend stores them (including thetypevalues it writes) and running the resulting rule against transactions.Same class of issue as #46 and #67, which covered other field/type values.