refactor: Enable mypy strict mode#210
Merged
Merged
Conversation
Enable the remaining strict flags (disallow_any_generics, disallow_untyped_defs, disallow_incomplete_defs) and consolidate to `strict = true` since all individual strict checks are now satisfied. - Annotate remaining untyped functions and parameters across the library. - Tighten generic types: `dict` -> `dict[str, Any]`, `Column` -> `Column[Any]`, `Select` -> `SelectOfScalar[int | None]`. - Raise `ActualDecryptionError` when optional encryption metadata fields are missing instead of letting `b64decode(None)` fail. - Rename a shadowed `balance` local in `_get_category_detailed_budget` to keep the Decimal-typed result distinct from the `int | None` scalar query result. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 97.49% 97.44% -0.06%
==========================================
Files 22 22
Lines 3277 3282 +5
==========================================
+ Hits 3195 3198 +3
- Misses 82 84 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the remaining strict flags (disallow_any_generics, disallow_untyped_defs, disallow_incomplete_defs) and consolidate to
strict = truesince all individual strict checks are now satisfied.dict->dict[str, Any],Column->Column[Any],Select->SelectOfScalar[int | None]. For some of them, there was no real better choice than choosingAny.ActualDecryptionErrorwhen optional encryption metadata fields are missing instead of lettingb64decode(None)fail.balancelocal in_get_category_detailed_budgetto keep the Decimal-typed result distinct from theint | Nonescalar query result.