Skip to content

links-Update oauthproxy.go #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romashka-btc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

links-Update oauthproxy.go #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions internal/proxy/oauthproxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,23 +331,23 @@ func (p *OAuthProxy) OAuthStart(rw http.ResponseWriter, req *http.Request, tags
// We redirect the browser to the authenticator with a 302 status code. The target URL is
// constructed using the GetSignInURL() method, which encodes the following data:
//
// * client_id: Defined by the OAuth2 RFC https://tools.ietf.org/html/rfc6749.
// * client_id: Defined by the OAuth2 RFC https://datatracker.ietf.org/doc/html/rfc6749
// Identifies the application requesting authentication information,
// from our perspective this will always be static since the client
// will always be sso proxy
//
// * redirect_uri: Defined by the OAuth2 RFC https://tools.ietf.org/html/rfc6749.
// * redirect_uri: Defined by the OAuth2 RFC https://datatracker.ietf.org/doc/html/rfc6749
// Informs the authenticator _where_ to redirect the user back to once
// they have authenticated with the auth provider and given us permission
// to access their auth information
//
// * response_type: Defined by the OAuth2 RFC https://tools.ietf.org/html/rfc6749.
// * response_type: Defined by the OAuth2 RFC https://datatracker.ietf.org/doc/html/rfc6749
// Required by the spec and must be set to "code"
//
// * scope: Defined by the OAuth2 RFC https://tools.ietf.org/html/rfc6749.
// * scope: Defined by the OAuth2 RFC https://datatracker.ietf.org/doc/html/rfc6749
// Used to offer different auth scopes, but will be unnecessary in the context of SSO.
//
// * state: Defined by the OAuth2 RFC https://tools.ietf.org/html/rfc6749.
// * state: Defined by the OAuth2 RFC https://datatracker.ietf.org/doc/html/rfc6749
// Used to prevent cross site forgery and maintain state across the client and server.

key := aead.GenerateKey()
Expand Down