Skip to content

Conversation

@ChristopheDujarric
Copy link
Contributor

No description provided.

@github-actions
Copy link

ℹ️ API content change detected:

No structural change, nothing to display.

Powered by Bump.sh

Copy link
Member

@paulRbr paulRbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🙏.

I'm wondering, why is the API document in your PR not the latest published train travel API?

Also I left an important comment which is preventing me to approve (about a missing external ref file)

x-topics:
- title: Getting started
content:
$ref: ./docs/getting-started.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your missing an external ref file. Could you also add that file in the PR (to make sure the deploy works fine).

@ChristopheDujarric
Copy link
Contributor Author

ChristopheDujarric commented Dec 2, 2024

@paulRbr, thanks for spotting the missing file; I've been too quick with that!

I took an old version of the API doc on purpose, and I will then upload a new version (with the updated parameters and the mock servers, but removing the mention of Postman and Insomnia), which will generate an interesting changelog entry.

@paulRbr paulRbr merged commit 3bb9506 into main Dec 2, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants