Skip to content

Improve docName and mcpServerName#828

Open
Polo2 wants to merge 1 commit into
mainfrom
bump-workspace-api--read-doc_name-in-response
Open

Improve docName and mcpServerName#828
Polo2 wants to merge 1 commit into
mainfrom
bump-workspace-api--read-doc_name-in-response

Conversation

@Polo2

@Polo2 Polo2 commented Jun 9, 2026

Copy link
Copy Markdown
Member

We know commands bump deploy --doc (or --mcp-server) can receive an id,
and we don't want this id to be used as CLI output

So we can use the doc_name (for API version),
and mcp_server_name (for MCP Server version),
that can be returned by the Bump.sh workflow API:
cf https://github.com/bump-sh/bump/pull/8623

@Polo2 Polo2 self-assigned this Jun 11, 2026
@Polo2 Polo2 force-pushed the bump-workspace-api--read-doc_name-in-response branch from 1e88703 to 3d4a4d8 Compare June 11, 2026 12:09
Comment thread src/api/models.ts Outdated
@Polo2 Polo2 force-pushed the bump-workspace-api--read-doc_name-in-response branch from 3d4a4d8 to 6d7ce46 Compare June 11, 2026 12:19
@Polo2

Polo2 commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

1st call, use id as doc parameter with the real bump-cli ( current behavior)

2nd call, use id as doc parameter with this branch: Documentation name replaces the id

image

@Polo2 Polo2 force-pushed the bump-workspace-api--read-doc_name-in-response branch from 6d7ce46 to fbe2d3e Compare June 11, 2026 12:39
We know commands bump deploy --doc (or --mcp-server)
can receive an `id`,
and we don't want this id to be used as CLI output

So we can use the doc_name (for API version),
and mcp_server_name (for MCP Server version),
that can be returned by the Bump.sh workflow API:
cf bump-sh/bump#8623

Include doc_name in object `DiffResponse`,
that will be exported to the github-action,
as output of command Diff.run
@Polo2 Polo2 force-pushed the bump-workspace-api--read-doc_name-in-response branch from fbe2d3e to 62ca185 Compare June 11, 2026 19:57
@Polo2 Polo2 requested a review from paulRbr June 12, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant