Skip to content

Refactor the flush method#99

Open
gazayas wants to merge 1 commit intomainfrom
features/notify-when-js-is-empty
Open

Refactor the flush method#99
gazayas wants to merge 1 commit intomainfrom
features/notify-when-js-is-empty

Conversation

@gazayas
Copy link
Copy Markdown

@gazayas gazayas commented Jun 27, 2023

If no JavaScript is recorded, output is simply an empty array, so the following else statement never gets the chance to run:

if output
  # ...
else
  puts "`window.testingOutput` was empty in the browser. Something must be wrong on the browser side."
end

I shifted things around so we notify the user that no JavaScript was recorded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant