Enhancement: Non-root help display, improved process hygiene, and safety checks #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2025 09:10
- Moved `display_help` to top and added early argument scanning to allow viewing help without requiring `sudo` or triggering dependency checks. - Updated `PATH` export to append to existing system path rather than overwriting it, preserving custom environment paths. - Enhanced `cleanup()` to kill child processes (orphans) upon script exit or interruption. - Added pre-flight check for 500MB free disk space in cache directory to prevent restic crashes. - Removed unreachable `--help` case from main execution block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The script now checks for
-h/--helpimmediately upon execution. This allows to read the documentation without entering a root password or waiting for dependency checks.The
PATHvariable is now appended (:$PATH) instead of overwritten, ensuring custom binaries in the user's environment are still accessible.Added a
cleanuptrap improvement that sendspkillto child processes, ensuring that if the script is cancelled (Ctrl+C), the underlyingresticprocess terminates immediately.Added a pre-flight check to ensure at least 500MB of free space exists in the cache directory/tmp before starting a backup.