Refactor lifecycle/cmd/restorer to move logic out of main and into phase package#1338
Draft
natalieparellano wants to merge 2 commits intomainfrom
Draft
Refactor lifecycle/cmd/restorer to move logic out of main and into phase package#1338natalieparellano wants to merge 2 commits intomainfrom
natalieparellano wants to merge 2 commits intomainfrom
Conversation
natalieparellano
force-pushed
the
refactor/new-restorer
branch
from
07b2e37 to
90c5aa3
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
refactor/new-restorer
branch
from
90c5aa3 to
67ec91e
Compare
| return metadata != nil && metadata.OS != "" | ||
| } | ||
|
|
||
| func (r *Restorer) updateAnalyzedMD() error { |
Member
Author
There was a problem hiding this comment.
Suggested change
| func (r *Restorer) updateAnalyzedMD() error { | |
| func (r *Restorer) updateAnalyzedMDRunImageTarget() error { |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is still somewhat a WIP - I need to update the code comments and also add unit tests, as that's a major advantage of this refactor.
Release notes
Related
Resolves #___
Context