Skip to content

Update source_control.md #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephanieatte wants to merge 1 commit into from
Closed

Update source_control.md #2080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pages/integrations/source_control.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ Buildkite integrates with several popular code repository management systems (RM
* [Bitbucket Server](/docs/integrations/bitbucket-server)
* [Phabricator](/docs/integrations/phabricator)
* [Other Git servers](/docs/integrations/git)

Note: Commit Status uses the latest built commit on a pipeline
Copy link
Copy Markdown
Contributor

@mbelton-buildkite mbelton-buildkite Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stephanieatte, sorry this has taken me a while to get around to. Can you please unpack this a bit more for me? What is the issue customers are running into?

Copy link
Copy Markdown
Contributor Author

@stephanieatte stephanieatte May 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbelton-buildkite No worries, the Customers get confused about if the commit statuses feature works with the first or latest build on a pipeline. So having it explicitly stating this in our docs will be great

Copy link
Copy Markdown
Contributor

@mbelton-buildkite mbelton-buildkite May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a bit out of place here, what do you think about including it on the relevant pages? Thinking:

Looks like it's not supported or not mentioned in the others.

Perhaps just something like:

The commit status on a PR shows the result of the most recent build.

Copy link
Copy Markdown
Contributor Author

@stephanieatte stephanieatte May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbelton-buildkite I see but I didn't want to repeat the informtion, but I understand it looks out of place. we might have to put it on all the pages