feat(config): support a cached logs location#875
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
On it! Follow along with my review here: https://buildkite.com/buildkite/buildsworth-review-pull-request/builds/789 |
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read through the new cache config and buildkite-logs wrapper. I found a couple of non-blocking edge cases in the config/URL plumbing; this is L2 for me because it adds a dependency-backed client path rather than just config metadata.
Want to dig deeper? The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 789, then answer my questions about the findings.
Reject negative BKLOG_MAX_LOG_BYTES env values so they fall through to user config instead of disabling the size limit. Preserve file:// query params such as no_tmp_dir=true when normalizing cache URLs.
|
@buildsworth-bk throw ya boy another review |
1 participant
Description
This allows for configuration options for job log caching to be set, this will eventually allow for speedier resolution of job logs and allow for the CLI and MCP to work in harmony 💞
This is infrastructure only — no commands use Parquet yet. Follow-up PRs can wire
bk job log --search / --tailvia f.LogsClient.NewReaderByJobID.Changes
go-buildkiteclient (auth + HTTP transport)BKLOG_CACHE_URL(default:~/.bklogviabuildkite-logs)BKLOG_MAX_LOG_BYTES(optional; library default when unset)bk config get|set|listTesting
go test ./...)go fmt ./...)bk config set log_cache_url file://~/.bklogpersists andbk config get log_cache_urlreturns it