perf: Retry darwin-vz vsock connects faster#374
Draft
lox wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The darwin-vz helper was waiting 100ms between failed guest VSOCK connection attempts while the VM was still booting. The minimal darwin-vz harness uses a 10ms retry cadence, and local TTI experiments showed that the coarser production interval can add avoidable readiness latency before the first guest exec.
This changes only the guest VSOCK connect retry sleep from 100ms to 10ms. The overall launch timeout and serial fallback behavior stay the same; the helper just checks for guest readiness more frequently during the existing timeout window.
Local benchmark context from the rootfs boot experiments:
Validation:
scripts/build-darwin-vz-helper.sh dist/cleanroom-darwin-vz.appmise exec -- go test ./internal/backend/darwinvzA follow-up benchmark attempt against a fresh isolated state directory paid cold runtime preparation and timed out before producing useful warm TTI samples, so I did not include it as validation evidence.