Fix slugify for accented characters and apostrophes#46
Open
mhulet wants to merge 1 commit intobuildermethods:mainfrom
Open
Fix slugify for accented characters and apostrophes#46mhulet wants to merge 1 commit intobuildermethods:mainfrom
mhulet wants to merge 1 commit intobuildermethods:mainfrom
Conversation
The slugify function was stripping accented characters entirely (é→nothing) and inserting hyphens around apostrophes (d'accueil→d-accueil). This broke section ID matching for French, Spanish, German, and other languages. - Normalize Unicode NFD and strip diacritics (é→e, ü→u) - Remove apostrophes without inserting hyphens Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
é→e,ü→u)d'accueil→daccueil)This fixes section ID matching for non-English titles (French, Spanish, German, etc.).
Test plan
"Page d'accueil"slugifies topage-daccueil"Fonctionnalités"slugifies tofonctionnalites"Témoignages"slugifies totemoignages🤖 Generated with Claude Code