fix: call NotifyEventStored in MCP profiler test#329
Merged
butschster merged 1 commit intomasterfrom Apr 9, 2026
Merged
Conversation
After PR #328 moved storeProfile from Handle() to OnEventStored(), the MCP test's ingestViaHandler helper no longer populated profiler-specific tables. Add the missing NotifyEventStored call to match the real HTTP server flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing
reg.NotifyEventStored(ev)call in the MCP test'singestViaHandlerhelper so profiler-specific tables are populated before MCP tool queries run.Why
PR #328 moved
storeProfilefrom the profiler handler'sHandle()intoOnEventStored(). The MCP test bypasses the HTTP server'sEventServiceand callsstore.Store()directly, which doesn't trigger module hooks — leaving theprofilesandprofile_edgestables empty and causingTestMCP_ProfilerEndToEndto fail in CI.Testing
go test ./internal/mcp/ -run TestMCP_ProfilerEndToEnd -vpasses. Full suite (go test ./...) passes.