fix: decode RFC 2047 encoded-word in SMTP subject headers#322
Merged
butschster merged 1 commit intomasterfrom Mar 31, 2026
Merged
fix: decode RFC 2047 encoded-word in SMTP subject headers#322butschster merged 1 commit intomasterfrom
butschster merged 1 commit intomasterfrom
Conversation
SMTP subject headers containing non-ASCII characters arrive as MIME encoded-words (e.g. =?utf-8?Q?...?=). These were stored as-is, appearing garbled in the UI. Use mime.WordDecoder to decode them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Decode MIME encoded-words (RFC 2047) in SMTP email subject headers before storing them. Subjects like
=?utf-8?Q?Norris=E2=80=94Your?=are now correctly decoded to their readable form.Why
Non-ASCII characters in email subjects arrive as RFC 2047 encoded-words. Without decoding, they appear garbled in the UI (e.g.
=?utf-8?Q?...?=instead of readable text).How
mime.WordDecoder.DecodeHeader()call inparseEmail()before assigning the subject fieldmimepackage was already imported — no new dependenciesTesting
TestParseEmail_RFC2047Subjectwith 4 cases: Q-encoded, B-encoded, mixed encoded/plain, and plain subjectgo test ./modules/smtp/