Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 13 additions & 2 deletions internal/gen/proto/buf/protoschema/test/v1/constraints.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions internal/proto/buf/protoschema/test/v1/constraints.proto
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,11 @@ message ConstraintTest {
}
}
}];

repeated string is_list = 125 [
(buf.validate.field).repeated.min_items = 1,
(buf.validate.field).repeated.max_items = 10
];
}

message ConstraintTests {
Expand Down
8 changes: 8 additions & 0 deletions internal/protoschema/jsonschema/jsonschema.go
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,14 @@ func (p *Generator) generateField(entry *msgSchema, field protoreflect.FieldDesc
func (p *Generator) generateFieldValidation(entry *msgSchema, field protoreflect.FieldDescriptor, hasImplicitPresence bool, rules *validate.FieldRules, schema map[string]any) error {
if field.IsList() {
schema["type"] = jsArray
if rules.HasRepeated() {
if rules.GetRepeated().MinItems != nil {
schema["minItems"] = rules.GetRepeated().GetMinItems()
}
if rules.GetRepeated().MaxItems != nil {
schema["maxItems"] = rules.GetRepeated().GetMaxItems()
}
}
items := make(map[string]any)
schema["items"] = items
schema = items
Expand Down
2 changes: 1 addition & 1 deletion internal/testdata/codegenrequest/input.json

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading