This repository was archived by the owner on Jan 7, 2019. It is now read-only.
Prevent scroll to top after FastBoot rehydration #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the page was rendered by FastBoot and then rehydrated on the client, we should not jump to the top, because the user might have already scrolled down on the prerendered page while rehydration was running.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the page was rendered by FastBoot and then rehydrated on the client, we should not jump to the top, because the user might have already scrolled down on the prerendered page while rehydration was busy.
This PR is based on work by @jpdombrowski in jpdombrowski@44bb233 but has been fixed to not skip
_attachEvents()on first FastBoot client side transition and pass linting checks.