Update bubble-sort and radix-sort solutions#7
Open
nielsboecker wants to merge 5 commits intobtholt:mainfrom
Open
Update bubble-sort and radix-sort solutions#7nielsboecker wants to merge 5 commits intobtholt:mainfrom
nielsboecker wants to merge 5 commits intobtholt:mainfrom
Conversation
|
This PR appears to be doing more than described in the description. Maybe its worth a clean up? @btholt I see are other possible PRs that address that radix sort but do so without copying the Other PRs that are testing on an already sorted array (and thus insufficient): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Brian, brilliant course as always, thanks ♡
Bubble sort
Changed index to go only to length - 1. It worked to go up to length, but only implicitly because
10 > undefined === falseRadix sort
The second test in solution works, but only because the input array and the expected output are in fact references to the same array.
array.sort()actually performs string-based alphabetic sorting, so this is not what we would want (even though the algorithm is correct).