add sort condition to random radix sort test#24
Open
sindre-frisvold-git wants to merge 1 commit intobtholt:mainfrom
Open
add sort condition to random radix sort test#24sindre-frisvold-git wants to merge 1 commit intobtholt:mainfrom
sindre-frisvold-git wants to merge 1 commit intobtholt:mainfrom
Conversation
Author
|
additional info: I saw some other pull requests trying to fix the same issue but they made multiple unrelated changes as well. Thus I made this small pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sort condition to prevent numbers being compared alphabetically. This prevented the test to pass with a valid radix sort implementation.