generated from bitcoin-sv/template
-
Notifications
You must be signed in to change notification settings - Fork 8
Develop port #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
F1r3Hydr4nt
wants to merge
188
commits into
master
Choose a base branch
from
develop-port
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Develop port #127
+81,687
−1,936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption, master_certificate, peer_session, requested_certificate_set, verifiable_certificate) and remove sys.path hack in keys
…bump version to 1.0.8
…port Feature/auth/certificates port
… primitives (AES-CBC/GCM, legacy helpers)
… decrypt) compatible with Go ECIES
…llet integration and callbacks\n\n- Closes #55, #54, #53, #52, #51, #50, #49, #48\n- Implement session manager + helpers and re-export PeerSession\n- Handshake (nonce-based), general message sign/verify, cert req/resp\n- Integrate wallet interface for HMAC/sign/verify + encryption hooks\n- Callback registration APIs and safer invocation (snapshot)\n- Reduce cognitive complexity and add defensive checks\n- Best-effort stop() and secure_send() delegate
Feature/auth/certificates port
Refactor SimplifiedHTTPTransport: improve error handling and payload …
fix(utils): Update utils module with latest changes and absolute imports
feat(auth/clients): Add and update client modules under auth/clients
feat(auth/transports): Add and update modules under auth/transports
…d update all imports
Feature/auth/certificates port
…p implementations
refactor(chaintrackers): update imports to absolute paths and clean u…
chore(registry): translate comments to English and clean up code
… CLAUDE.md. Updated CHANGELOG.md
… CLAUDE.md. Updated CHANGELOG.md
…mplementations - Simplified method signatures by removing the unused `ctx` parameter. - Updated all affected method references, including tests and internal utilities. - Improved maintainability by aligning with streamlined parameter requirements. - Adjusted test cases for compatibility with the updated methods.
…ine cryptographic method calls - Updated cryptographic function arguments (`encrypt`, `decrypt`, `get_public_key`, `create_signature`) to align with BRC-100 flat structure (camelCase). - Removed unused `originator` parameter from method calls for consistency. - Improved TypeScript/Go parity by aligning method structures and argument naming conventions.
- Adjusted indentation for `encrypt_args` and `decrypt_args` dictionaries to maintain consistency and improve readability. - Ensured alignment with Python code style guidelines.
…idation and backward compatibility - Extended `_verify_your_nonce` to improve nonce verification for various scenarios, including session nonce matching and HMAC-based verification. - Updated `SimplifiedHTTPTransport` with improved response handling, including special cases for error status codes. - Enhanced varint reading and writing logic to handle special cases like `-1` (represented as `0xFFFFFFFFFFFFFFFF`) for better protocol compliance. - Added backward compatibility to handler signature checks in transport logic.
- Refactored `WalletImpl` to `ProtoWallet` across the codebase for consistent naming with SDKs. - Updated documentation and comments to reflect the new class name. - Retained `WalletImpl` as a deprecated alias for backward compatibility. - Adjusted all tests and imports to use `ProtoWallet`.
…TS/Go SDK compatibility - Implemented `SymmetricKey` class for AES-GCM encryption/decryption, aligned with TS/Go SDK behavior. - Defined `encrypt` and `decrypt` methods to support cross-SDK compliance. - Added `test_symmetric_key.py` with basic functionality tests and compatibility vectors from TS/Go SDKs. - Updated `ProtoWallet.encrypt` with AES-GCM encryption logic using the derived symmetric key. - Enhanced `test_proto_wallet_encrypt_decrypt` to validate cross-SDK encryption format against Go/TS SDKs.
…anced type safety and SDK parity - Replaced `Dict` arguments with specific `TypedDict` types (`GetPublicKeyArgs`, `EncryptArgs`, etc.) in method signatures. - Updated internal logic to handle TypedDict structures, improving compatibility with TS/Go SDKs. - Added backward-compatible support for tuple-based `protocolID` inputs in `get_public_key`. - Extended tests to validate encryption, decryption, and argument handling. - Enhanced type annotations in `wallet_interface.py` for clarity.
…llet` API - Added handling for special string counterparty values (`self`, `anyone`) for TS/Go SDK parity. - Enhanced argument handling with support for both camelCase and snake_case naming styles in `create_signature`, `verify_signature`, and related methods. - Updated default values for `counterparty` to align with TS behavior (`self` for verify, `anyone` for create). - Streamlined data type checks and normalizations in key-related methods. - Extended tests to cover new behavior and ensure consistency across SDKs.
…avior - Updated `counterparty` default to `SELF` (`type: 2`) for parity with TS SDK. - Enhanced ciphertext handling in encryption to support list-to-bytes conversion. - Adjusted decryption tests for compatibility with TS SDK's list-based plaintext format. - Refactored `SimplifiedHTTPTransport.send` for parameter consistency.
…and related methods - Removed the unused `ctx` parameter for simplified method signatures and improved maintainability. - Updated all related methods, including `_send_general_message`, `_send_non_general_message`, and `_notify_handlers`. - Adjusted test cases to align with the updated method signatures.
…idation - Replaced `suppress(Exception)` with specific `try`/`except` blocks for clearer exception management. - Added granular `ValueError` checks for incomplete or invalid data in `from_hex` and `from_reader` methods across `Transaction`, `TransactionInput`, and `TransactionOutput` classes. - Improved error messages to specify missing or incomplete data fields. - Updated docstrings to reflect changes in error handling behavior.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




Description of Changes
Added
Testing Procedure
Testing, along with coverage has been upgraded to a better structure. Legacy tests were ensured still pass.
Checklist:
CHANGELOG.mdwith my changes