Skip to content

Conversation

@WayOfTheQway
Copy link

So... Detection of trees with multiple block types (like trees with some logs sideways) would sometimes fail depending on what type of log you broke and if it was connected to others etc. That was fixed in the second commit. In the first commit, some stuff having to do with non-standard trees (ones that the logs weren't modulus, but rather one after the other) not being able to be defined correctly.

SnakeFang added 2 commits January 27, 2016 13:07
…ft config

Using ModulusBlockID with a modulus of 4 can mess up non-standard log
blocks (like Thaumcraft 5 logs - Greatwood is log:0 through log:2, and
Silverwood is log:3 through log:5) And I updated the Thaumcraft default
config so it works with Thaumcraft 5
…s fail.

The auto detection uses only the first log that was broken as the list
of BlockIDs, so if the TreeDef has other BlockIDs then the autodetect
doesn't realize this, and it would force the TreeDef to be null and make
everything else fail afterward.
@Lunatrius
Copy link
Collaborator

Probably missed the comment in the other PR. I've been converting the metadata stuff to block states, so the config will look like this:

        silverwood {
            S:leaves=thaumcraft:log[variant=silverwood]
            S:logs=thaumcraft:leaf[variant=silverwood]
        }

@WayOfTheQway
Copy link
Author

Okay. This was mostly just so I could have it working in my modded survival. I thought I may as well put it out there in case anyone else was having the same problems

@WayOfTheQway
Copy link
Author

First: Sorry I'm replying quite late, I kinda forgot that Github was a thing that I did sometimes.
Second: For the autodetection. When autodetection is enabled, it is the only method used to find TreeDef's, which is fine (if implemented correctly). But, the implementation used attempted to detect trees made solely out of the first block broken, so some trees (i.e. trees that have multiple BlockID's in them) would not get detected. Now to fix that you could either change the detection to check for all BlockID's in the original TreeDef, or do what I did and return the original TreeDef.
Third: Thaumcraft, is, well, how do I put this nicely? special. Thaumcraft is special. The logs do not use the common modular method, but instead are three in a row (X-axis, Y-axis, Z-axis) for each log type (Greatwood, Silverwood). The leaves, on the other hand, are every other block (yes, each leaf block has multiple types. But that's normal, seeing as placed leaves are different from grown leaves) So the leaf blocks need to be modular.
I think that's it. If anything I said isn't right, tell me and I'll look at it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants