Skip to content

fix: replace hardcoded frontend url with backend proxy #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basuri01 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −10
Open

fix: replace hardcoded frontend url with backend proxy #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions frontend/src/lib/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
const BASE = import.meta.env.VITE_API_URL || 'http://localhost:3000';

export async function api(path, options = {}) {
const res = await fetch(`${BASE}/api/v1${path}`, {
const res = await fetch(`/api/v1${path}`, {
credentials: 'include',
headers: {
'Content-Type': 'application/json',
Expand Down
4 changes: 1 addition & 3 deletions frontend/src/lib/sse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
const BASE = import.meta.env.VITE_API_URL || 'http://localhost:3000';

export function openEventStream(handlers) {
const url = `${BASE}/api/v1/events`;
const url = `/api/v1/events`;
const source = new EventSource(url, { withCredentials: true });

for (const [event, handler] of Object.entries(handlers)) {
Expand Down
20 changes: 16 additions & 4 deletions frontend/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,19 @@
import { defineConfig } from 'vite';
import { defineConfig, loadEnv } from 'vite';
import react from '@vitejs/plugin-react';

export default defineConfig({
plugins: [react()],
server: { port: 5173 },
export default defineConfig(({ mode }) => {
const env = loadEnv(mode, process.cwd(), '');

return {
plugins: [react()],
server: {
port: 5173,
proxy: {
'/api': {
target: env.VITE_API_URL || 'http://localhost:3000',
changeOrigin: true,
},
},
},
};
});