Skip to content

fix: attach only safe user fields to req.user #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ethnic17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: attach only safe user fields to req.user #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion backend/src/middleware/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,18 @@ async function attachUser(req, _res, next) {
const userId = req.cookies?.splitt_session;
if (!userId) return next();

const user = await prisma.user.findUnique({ where: { id: userId } });
const user = await prisma.user.findUnique({
where: { id: userId },
select: {
id: true,
email: true,
name: true,
picture: true,
phone: true,
thumbsUp: true,
thumbsDown: true,
},
});
if (user) req.user = user;
next();
}
Expand Down
3 changes: 1 addition & 2 deletions backend/src/modules/auth/auth.routes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ const { requireAuth } = require('../../middleware/auth');
const router = express.Router();

router.get('/me', requireAuth, (req, res) => {
const { id, email, name, picture, phone, thumbsUp, thumbsDown } = req.user;
res.json({ id, email, name, picture, phone, thumbsUp, thumbsDown });
res.json(req.user);
});

router.post('/logout', (_req, res) => {
Expand Down