fix: omit empty optional fields from payloads#16
Open
Luffy-D-Zoro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #14
This PR fixes validation failures when optional form fields are submitted empty.
Previously, some optional frontend fields were sent as
null:notesinPostRide.jsxmaxFareinPostIntent.jsxThe backend schemas treat these fields as optional, not nullable, so sending
nullcaused validation to fail.This PR changes the empty optional field values from
nulltoundefined.When the request payload is stringified, fields with
undefinedvalues are omitted from the JSON body. This matches the backend schemas where these fields are optional.Type of change
Proof of work
Tested locally:
Checklist
feature/,fix/,docs/)