Skip to content

Map fixme markers: light blue when object is a relation member #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tordans wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Map fixme markers: light blue when object is a relation member #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/Shared/MapMarkers/FixmeMarker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,15 @@
//

import Foundation
import UIKit

// An OSM object containing a fixme= tag
final class FixmeMarker: MapMarker {
/// Same light blue as relation member highlighting in EditorMapLayer.
private static let relationMemberColor = UIColor(red: 66 / 255.0,
green: 188 / 255.0,
blue: 244 / 255.0,
alpha: 1.0)
let fixmeID: OsmExtendedIdentifier

override var markerIdentifier: String {
Expand Down Expand Up @@ -39,6 +45,28 @@ final class FixmeMarker: MapMarker {

override var buttonLabel: String { "F" }

private var isRelationMember: Bool {
guard let object = object else { return false }
return !object.parentRelations.isEmpty
}

override func makeButton() -> UIButton {
let button = super.makeButton()
applyButtonStyle()
return button
}

override func reuseButtonFrom(_ other: MapMarker) {
super.reuseButtonFrom(other)
applyButtonStyle()
}

private func applyButtonStyle() {
guard let button = button else { return }
let color = isRelationMember ? Self.relationMemberColor : .blue
button.layer.backgroundColor = color.cgColor
}

override func handleButtonPress(in mainView: MainViewController, markerView: MapMarkersView) {
if mainView.mapView.isHidden {
// show the fixme text
Expand Down
Loading