Skip to content

Conversation

@drmick
Copy link
Member

@drmick drmick commented Jan 8, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None] / [Yes]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None] / [Yes]


COMPATIBILITY

Affected features:

  • [State]
  • [State. Blockchain Config]
  • [Block]
  • [Block Proof]
  • [Archive]
  • [Persistent State]
  • [Persistent Queue]
  • [Storage. Blocks]
  • [Storage. States]
  • [Storage. Archives]
  • [Queue. Diff]
  • [Queue. Storage]
  • [Queue. Storage. Statistics]
  • [Message Processing Algorithm]
  • [ProcessedUpto]
  • [Collator. Limits]
  • [Collator. Work Units Calculation]
  • [Mempool. Consensus Config]
  • [Mempool. Validation rules]
  • [Mempool. Storage]
  • [Mempool. API tl models]

SPECIAL DEPLOYMENT ACTIONS

[Not Required] / [Required]


PERFORMANCE IMPACT

[No impact expected] / [Expected impact]


TESTS

Unit Tests

[Covered by:] / [No coverage]

Network Tests

[Covered by:] / [No coverage]

Manual Tests

[Manual tests used]

  • [1-255]
  • [transfers]
  • [swaps]

Notes/Additional Comments:

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=995

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=995
  • Run specific test: gh workflow run network-tests.yml -f pr_number=995 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@drmick drmick changed the title Feature/collator undo 2 Collator state undo Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@drmick drmick added this to the 010 Collator - improvements milestone Jan 15, 2026
@drmick drmick linked an issue Jan 15, 2026 that may be closed by this pull request
5 tasks
@drmick drmick added enhancement New feature or request C-collator Collator module labels Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 92.90458% with 203 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.55%. Comparing base (587cb96) to head (158ab33).
⚠️ Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...ator/src/collator/messages_reader/state/int/mod.rs 28.12% 23 Missing ⚠️
collator/src/collator/statistics/cumulative.rs 95.44% 15 Missing and 6 partials ⚠️
util-proc/src/derive_transactional.rs 87.19% 19 Missing and 2 partials ⚠️
...collator/messages_reader/state/ext/range_reader.rs 65.51% 18 Missing and 2 partials ⚠️
collator/src/internal_queue/types/stats.rs 93.14% 18 Missing and 1 partial ⚠️
...r/src/collator/messages_reader/externals_reader.rs 82.02% 14 Missing and 2 partials ⚠️
...r/src/collator/messages_reader/state/int/reader.rs 76.92% 15 Missing ⚠️
...lator/src/collator/do_collate/execution_wrapper.rs 62.50% 5 Missing and 4 partials ⚠️
collator/src/collator/messages_buffer.rs 97.94% 8 Missing and 1 partial ⚠️
util/src/transactional_types.rs 85.48% 4 Missing and 5 partials ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
+ Coverage   46.27%   55.55%   +9.28%     
==========================================
  Files         360      413      +53     
  Lines       62586    69089    +6503     
  Branches    62586    69089    +6503     
==========================================
+ Hits        28962    38385    +9423     
+ Misses      32115    28881    -3234     
- Partials     1509     1823     +314     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-collator Collator module enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make collator tasks cancel-safe

2 participants