fix: build system reliability fixes and docs corrections#371
Open
Sireeshreddy01 wants to merge 1 commit intobrowseros-ai:mainfrom
Open
fix: build system reliability fixes and docs corrections#371Sireeshreddy01 wants to merge 1 commit intobrowseros-ai:mainfrom
Sireeshreddy01 wants to merge 1 commit intobrowseros-ai:mainfrom
Conversation
Sireeshreddy01
commented
Feb 19, 2026
- Remove temp file leak in CompileModule._create_version_file: write VERSION directly via Path.write_text() instead of tempfile+shutil.copy2
- Always close build log: add finally: close_log_file() in execute_pipeline() so logs are flushed on success, failure, and KeyboardInterrupt
- Fix fragile series patch comment stripping: change ' #' to ' # ' (GNU Quilt convention) so patch filenames containing ' #' are preserved
- Move IS_MACOS to module-level import in git.py, remove redundant inner-function re-import in SparkleSetupModule.validate()
- Validate build_type in ConfigureModule.validate(): reject values other than 'debug' or 'release' with a clear error message
- Fix CONTRIBUTING.md build commands: correct binary name to 'browseros build', fix non-existent config filenames (debug.macos.yaml -> debug.yaml), remove --chromium-src which conflicts with --config mode
- Remove stale 'Coming soon' from Graph Mode card in docs/index.mdx and add href to the existing /features/workflows page
Author
|
have read the CLA Document and I hereby sign the CLA |
Contributor
|
CLA Assistant Lite bot ✅ All contributors have signed the CLA. Thank you for helping make BrowserOS better! |
Greptile SummaryThis PR enhances build system reliability through multiple focused fixes:
All changes are non-breaking improvements that fix edge cases and improve developer experience. Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[execute_pipeline] -->|try block| B[Execute modules sequentially]
B -->|success| C[Log success & notify_pipeline_end]
B -->|KeyboardInterrupt| D[Log error & notify_pipeline_error]
B -->|ValidationError| E[Log validation failure & notify_pipeline_error]
B -->|Exception| F[Log pipeline failure & notify_pipeline_error]
C -->|finally| G[close_log_file]
D -->|finally| G
E -->|finally| G
F -->|finally| G
G --> H[Ensure log file flushed & closed]
I[CompileModule._create_version_file] -->|old approach| J[tempfile.NamedTemporaryFile]
J --> K[shutil.copy2]
K --> L[Path.unlink temp file]
I -->|new approach| M[Path.write_text directly]
M --> N[No temp file leak]
Last reviewed commit: 2ce58bb |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
- Remove temp file leak in CompileModule._create_version_file: write VERSION directly via Path.write_text() instead of tempfile+shutil.copy2 - Always close build log: add finally: close_log_file() in execute_pipeline() so logs are flushed on success, failure, and KeyboardInterrupt - Fix fragile series patch comment stripping: change ' #' to ' # ' (GNU Quilt convention) so patch filenames containing ' #' are preserved - Move IS_MACOS to module-level import in git.py, remove redundant inner-function re-import in SparkleSetupModule.validate() - Validate build_type in ConfigureModule.validate(): reject values other than 'debug' or 'release' with a clear error message - Fix CONTRIBUTING.md build commands: correct binary name to 'browseros build', fix non-existent config filenames (debug.macos.yaml -> debug.yaml), remove --chromium-src which conflicts with --config mode - Remove stale 'Coming soon' from Graph Mode card in docs/index.mdx and add href to the existing /features/workflows page
2ce58bb to
0baad8e
Compare
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.