-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: adding Opus 4.6 to model list for computer use #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ export const modelToAgentProviderMap: Record<string, AgentProviderType> = { | |
| "claude-sonnet-4-20250514": "anthropic", | ||
| "claude-sonnet-4-5-20250929": "anthropic", | ||
| "claude-opus-4-5-20251101": "anthropic", | ||
| "claude-opus-4-6": "anthropic", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check that Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/core/lib/v3/agent/AgentProvider.ts
Line: 23:23
Comment:
Check that `claude-opus-4-6` is the official model identifier from Anthropic's API. All other Claude models include date suffixes (e.g., `claude-opus-4-5-20251101`), but this one doesn't follow the pattern.
How can I resolve this? If you propose a fix, please make it concise. |
||
| "claude-haiku-4-5-20251001": "anthropic", | ||
| "gemini-2.5-computer-use-preview-10-2025": "google", | ||
| "gemini-3-flash-preview": "google", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -371,6 +371,7 @@ export const AVAILABLE_CUA_MODELS = [ | |
| "openai/computer-use-preview-2025-03-11", | ||
| "anthropic/claude-3-7-sonnet-latest", | ||
| "anthropic/claude-opus-4-5-20251101", | ||
| "anthropic/claude-opus-4-6", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: Rule violated: Ensure we never check against hardcoded lists of allowed LLM model names Avoid extending hardcoded allowlists of LLM model names. The rule requires accepting any provider/model-name instead of adding more entries to lists like AVAILABLE_CUA_MODELS; please replace this allowlist-based check with validation that does not hardcode model names (unless explicitly blocking known-bad models). Prompt for AI agents |
||
| "anthropic/claude-haiku-4-5-20251001", | ||
| "anthropic/claude-sonnet-4-20250514", | ||
| "anthropic/claude-sonnet-4-5-20250929", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,7 @@ describe("LLM and Agents public API types", () => { | |
| "openai/computer-use-preview-2025-03-11", | ||
| "anthropic/claude-3-7-sonnet-latest", | ||
| "anthropic/claude-opus-4-5-20251101", | ||
| "anthropic/claude-opus-4-6", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: Rule violated: Ensure we never check against hardcoded lists of allowed LLM model names This change extends a hardcoded allow-list of LLM model names. The rule (“Ensure we never check against hardcoded lists of allowed LLM model names”) forbids adding or updating such lists, even in tests. Please refactor the test to avoid asserting against a fixed model-name list (e.g., validate provider/model-name format or defer to provider validation) instead of enumerating specific models. Prompt for AI agents |
||
| "anthropic/claude-haiku-4-5-20251001", | ||
| "anthropic/claude-sonnet-4-20250514", | ||
| "anthropic/claude-sonnet-4-5-20250929", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Rule violated: Ensure we never check against hardcoded lists of allowed LLM model names
This change adds a hardcoded allowed model name to the model-to-provider map, violating the rule to avoid hardcoded lists of allowed LLM models. Update the logic to accept any model name (preferably provider/model-name) and let the provider validate availability instead.
Prompt for AI agents