test: cover remote daemon env forwarding#350
Open
honor2030 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_remote_daemon()forwards the resolved remote websocket and Browser Use browser id intoensure_daemon().BU_CDP_WS.Refs #181.
Test Plan
uv run --with pytest --with pillow python -m pytest tests/unit/test_admin.py -quv run --with pytest --with pillow python -m pytest tests -quv run python -m compileall src testsuv pip check --python .venv/bin/pythonuv run --with ruff python -m ruff check --select B tests/unit/test_admin.pySummary by cubic
Add a regression test to ensure start_remote_daemon forwards the resolved remote CDP websocket and browser ID to ensure_daemon via env vars. Confirms
BU_CDP_WSandBU_BROWSER_IDare set so the daemon doesn’t fall back to local Chrome discovery (guards against #181).Written for commit 559bc1b. Summary will update on new commits.