fix(test): query active_sessions with declared window "now" (A1 follow-up)#119
Merged
Merged
Conversation
…t_30 A1 follow-up) The A1 fix (#118) makes GET /v1/metrics reject a window the metric doesn't declare. The e2e support-agent journey and the support-agent example queried active_sessions — a point-in-time gauge whose only declared window is "now" — with window="1h", which the old code silently computed as a 30-minute count and echoed back as "1h". Post-merge that correctly returns 422, which turned E2E Tests + Staging Deploy red on main. Use window="now" in the e2e journey and the example, and extend the A1 unit test to pin that active_sessions?window=now returns 200. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DORA Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #118. The A1 metric-window validation correctly rejects undeclared windows; the e2e support-agent journey and the example queried
active_sessions(point-in-time gauge, only windownow) with1h, which the old code silently accepted — so post-merge E2E Tests + Staging Deploy went red. Switch both towindow=nowand pinactive_sessions?window=now→ 200 in the A1 unit test.🤖 Generated with Claude Code