Using packed structs instead of ORed consts #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bronter
reviewed
Jul 17, 2025
bronter
reviewed
Jul 17, 2025
Owner
|
Since the packed structs evaluate to the same values as the flags, I don't think we need to bother with bitcasting them for WGPU structs, it's fine as-is. |
Owner
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to @filipcro's suggestion in #23, which I mentioned in #24
I will mention that, as it is right now, the extern structs are using the packed struct by themselves, instead of WGPUFlags. But since said packed structs are all backed by WGPUFlags, it still works.
Whether you'd prefer the WGPU structs to use raw WGPUFlags and use bit casts when converting the zig structs to wgpu structs or leave it as is, I'll leave it up to you.