Open
Conversation
Owner
|
Thanks for the great pr. I’ll review it as soon as possible. |
|
When is this coming? It would be good to have it released. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements to the
SignalRGBPluginandsignalrgb.pyfiles, including integration with the Cider app and enhancements to the font handling. The most important changes include adding support for the Cider music overlay, updating font paths and sizes, and enhancing the composition and rendering logic.Cider Integration:
musicOverlayandmusicTokentoSignalRGBPlugin/KrakenLCDBridge.jsto enable and configure the Cider music overlay.setupCiderConnection,handlePlaybackUpdate, andupdateMusicInfomethods insignalrgb.pyto manage the connection and data retrieval from the Cider app.renderOverlaymethod insignalrgb.pyto display music information and album art when the music overlay is enabled.Font Handling:
signalrgb.pyto improve text rendering.updateFontsmethod to handle different font sizes and weights.Composition and Rendering:
composeandaddOverlaymethods insignalrgb.pyto handle the new music overlay and ensure proper image download and usage. [1] [2]oncompositionChangedandontextOverlayChangedmethods inSignalRGBPlugin/KrakenLCDBridge.jsto add or remove properties based on the overlay settings.Miscellaneous:
fonts/Figree-LICENSE.mdfor the Figtree font.SignalRGBPlugin/KrakenLCDBridge.jsfor consistency. [1] [2] [3]These changes collectively enhance the functionality and user experience of the SignalRGB plugin, especially with the new music overlay feature and improved font handling.
Preview: