Skip to content

feat(PE-1271): add seamless video switching example#128

Merged
jdmedlin1 merged 7 commits into
mainfrom
PE-1271-final
Jun 25, 2026
Merged

feat(PE-1271): add seamless video switching example#128
jdmedlin1 merged 7 commits into
mainfrom
PE-1271-final

Conversation

@jdmedlin1

Copy link
Copy Markdown
Contributor

📝 Description

Dual HTML5 video element implementation for gap-free playback on BrightSign players. Background-preloads the next video so transitions are instant with no black frames or freeze.

Issue: Url to Jira Issue

📋 List of Changes

  • Add missing <script src="index.js"> tag (JS was never loaded)
  • Remove stray closing tag and duplicate CSS rules
  • Correct architecture.md reference from bundle.js to index.js

✔️ Dev Complete Checklist

  • PR template filled out
  • Change is tested by submitter
  • PR follows all linting and coding standards
  • Github Issue exists (if applicable)
  • Team member has been assigned
  • At least one commit message is in Conventional Commit format

Dual HTML5 video element implementation for gap-free playback on
BrightSign players. Background-preloads the next video so transitions
are instant with no black frames or freeze.

Includes review fixes from the original draft:
- Add missing <script src="index.js"> tag (JS was never loaded)
- Remove stray closing </video> tag and duplicate CSS rules
- Correct architecture.md reference from bundle.js to index.js
@jdmedlin1 jdmedlin1 self-assigned this Jun 11, 2026
Copilot AI review requested due to automatic review settings June 11, 2026 16:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new browser example demonstrating “seamless” (gap-free) HTML5 video playback on BrightSign players by alternating between two stacked video elements while preloading the next asset in the background.

Changes:

  • Added a new seamless-video-switching example (HTML/JS + BrightScript autorun) implementing dual-video playback with background preloading.
  • Documented deployment and architecture for the new example (README + Mermaid diagram).
  • Registered the new example in examples/README.md.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
examples/README.md Adds the new example to the Browser Examples compatibility matrix.
examples/browser/seamless-video-switching/README.md Documents the approach, configuration, and SD-card deployment steps.
examples/browser/seamless-video-switching/index.js Implements the dual-player playlist logic (preload + switch).
examples/browser/seamless-video-switching/index.html Provides the two stacked <video> elements and loads index.js.
examples/browser/seamless-video-switching/autorun.brs Launches the HTML app via roHtmlWidget with Node enabled.
examples/browser/seamless-video-switching/architecture.md Mermaid diagram + narrative flow describing the intended switching behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/browser/seamless-video-switching/index.js Outdated
Comment thread examples/browser/seamless-video-switching/index.js
Comment thread examples/README.md Outdated
Comment thread examples/browser/seamless-video-switching/README.md
Also note the Node fs dependency in the README listing.
…ormance based on hardware and software versions
…lti-decoder variant

- Fix missing <script> tag that prevented index.js from loading
- Defer visibility swap until hidden player fires 'playing' to avoid unrendered frames
- Add multi-decoder variant using pre-warming and early start for near-zero-gap transitions
- Align single-decoder index.js style with multi-decoder variant
@jdmedlin1 jdmedlin1 requested a review from blshukla June 23, 2026 19:19
blshukla
blshukla previously approved these changes Jun 23, 2026

@blshukla blshukla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread examples/browser/seamless-video-switching/index.js Outdated
@jdmedlin1 jdmedlin1 merged commit 88ec753 into main Jun 25, 2026
3 checks passed
@jdmedlin1 jdmedlin1 deleted the PE-1271-final branch June 25, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants