Skip to content

Add toISOString() methods #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenMorel merged 2 commits into from
Oct 3, 2023
Merged

Add toISOString() methods #87

BenMorel merged 2 commits into from
Oct 3, 2023

Conversation

@gnutix
Copy link
Contributor

@gnutix gnutix commented Oct 2, 2023

No description provided.

@gnutix gnutix mentioned this pull request Oct 2, 2023
Merged
@gnutix gnutix force-pushed the add-tostring-methods branch from 597381c to 8109088 Compare October 2, 2023 07:27
@gnutix
Copy link
Contributor Author

gnutix commented Oct 2, 2023

I removed Month::getName() and DayOfWeek::toISOString(). PR is ready for merge IMHO.

BenMorel
BenMorel requested changes Oct 2, 2023
View reviewed changes
@gnutix
Copy link
Contributor Author

gnutix commented Oct 3, 2023 •
edited
Loading

@BenMorel Could you merge #85 first, and then I'll rebase this PR on master and do the changes you requested ? (otherwise if I move __toString()'s implementation in toString() first and then rebase, I'll get tons of conflicts)

@BenMorel
Copy link
Member

BenMorel commented Oct 3, 2023

@gnutix I was actually planning to do the opposite, as I haven't reviewed #85 yet!

Plus, you said in #85 that you needed a bug fix from here?

@gnutix gnutix force-pushed the add-tostring-methods branch from 8109088 to 87a773a Compare October 3, 2023 15:39
@gnutix
Copy link
Contributor Author

gnutix commented Oct 3, 2023 •
edited
Loading

All the review comments have been fixed. I think I found a way to do the changes without having to worry about conflicts... we'll see.

Plus, you said in #85 that you needed a bug fix from here?

I cherry-picked the same bugfix commit in both branches. Whichever gets merged first puts the commit into master, and the other one will drop it upon rebase.

@gnutix gnutix force-pushed the add-tostring-methods branch from 87a773a to 8c084d0 Compare October 3, 2023 15:41
@gnutix gnutix force-pushed the add-tostring-methods branch from 8c084d0 to 365ffc4 Compare October 3, 2023 15:44
@gnutix gnutix requested a review from BenMorel October 3, 2023 15:46
@BenMorel BenMorel merged commit 5eeba96 into brick:master Oct 3, 2023
@BenMorel
Copy link
Member

BenMorel commented Oct 3, 2023

Thank you, @gnutix! I'm slightly concerned about YearMonthRange::toISOString() as I cannot confirm whether this is part of ISO 8601; but it is close enough to other representations, and if ISO 8601 did standardize this, I'm confident it would have this format.

@BenMorel
Copy link
Member

BenMorel commented Oct 3, 2023

Can you please rebase #85?

@gnutix
Copy link
Contributor Author

gnutix commented Oct 3, 2023 •
edited
Loading

Can you please rebase #85?

Sure, first thing tomorrow morning. After it's merged, would you mind doing a release ?

@BenMorel
Copy link
Member

BenMorel commented Oct 3, 2023

@gnutix I'll do what I can 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenMorel BenMorel Awaiting requested review from BenMorel

1 more reviewer

@someniatko someniatko someniatko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gnutix @BenMorel @someniatko