Fixing syntax for K2SE compatibility in Factorio 2.0#23
Open
dylanmcsweeney wants to merge 1 commit intobrevven:masterfrom
Open
Fixing syntax for K2SE compatibility in Factorio 2.0#23dylanmcsweeney wants to merge 1 commit intobrevven:masterfrom
dylanmcsweeney wants to merge 1 commit intobrevven:masterfrom
Conversation
Author
|
Also, I don't know exactly what is supposed to be there, but line data-util.lua:639 looks like a typo to me. Here it is: I don't know if that's on purpose or not, but it stood out so I thought I would mention it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the SE code path is enabled with a testing version of SE for Factorio 2.0 (plus a K2SE save file), titanium mod fails to load because of new Lua syntax requirements for things like "results" and "ingredients" in Factorio 2.0. I am not a Lua programmer (just Python and C++), so this is just what ChatGPT suggested I change then cleaned up by me. But, as far as I can tell it fixes the problem and I am able to load my save file.