Skip to content

Ensure richmond region is used for testing + make clear which nodes are test-related #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianlechthaler wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Ensure richmond region is used for testing + make clear which nodes are test-related #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
296e9c7
use test-<UUID> as node name
brianlechthaler Feb 26, 2026
a670a0d
set default test region to richmond
brianlechthaler Feb 26, 2026
e5d3974
use region richmond for providerconfig in testinstancelifecyclevalida…
brianlechthaler Feb 26, 2026
05477df
use region richmond when calling MakeClient
brianlechthaler Feb 27, 2026
75d02ac
Merge branch 'main' into optimize_sfc_tests
brianlechthaler Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions v1/providers/sfcompute/scripts/instancetype_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func TestGetInstanceTypes(t *testing.T) {
apiKey := getAPIKey()

credential := NewSFCCredential("validation-test", apiKey)
client, err := credential.MakeClient(context.Background(), "eu-north1")
client, err := credential.MakeClient(context.Background(), "richmond")
if err != nil {
t.Fatalf("failed to make client: %v", err)
}
Expand Down Expand Up @@ -50,19 +50,19 @@ func TestCreateInstance(t *testing.T) {
apiKey := getAPIKey()

credential := NewSFCCredential("validation-test", apiKey)
client, err := credential.MakeClient(context.Background(), "eu-north1")
client, err := credential.MakeClient(context.Background(), "richmond")
if err != nil {
t.Fatalf("failed to make client: %v", err)
}

id := uuid.New().String()

instance, err := client.CreateInstance(context.Background(), v1.CreateInstanceAttrs{
Name: "test",
Name: fmt.Print("test-%s", id),
RefID: id,
PublicKey: ssh.GetTestPublicKey(),
InstanceType: "h100",
Location: "hayesvalley",
Location: "richmond",
})
if err != nil {
t.Fatalf("failed to create instance: %v", err)
Expand Down
2 changes: 1 addition & 1 deletion v1/providers/sfcompute/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestInstanceLifecycleValidation(t *testing.T) {

config := validation.ProviderConfig{
Credential: NewSFCCredential("validation-test", apiKey),
Location: "yerba",
Location: "richmond",
}

validation.RunInstanceLifecycleValidation(t, config)
Expand Down