Skip to content

Timeout for analytics #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theFong wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Timeout for analytics #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21ac113
perf(analytics): timeout GPU info collection at 100ms
theFong Feb 28, 2026
7d0cbf6
perf(analytics): timeout parent process info collection at 100ms
theFong Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pkg/analytics/parentprocess.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,29 @@ import (
"runtime"
"strconv"
"strings"
"time"
)

// getParentProcessInfo returns the name and full command line of the parent process.
// Times out after 100ms to avoid blocking the CLI.
func getParentProcessInfo() (name, cmdline string) {
type result struct {
name, cmdline string
}
ch := make(chan result, 1)
go func() {
n, c := getParentProcessInfoSync()
ch <- result{name: n, cmdline: c}
}()
select {
case r := <-ch:
return r.name, r.cmdline
case <-time.After(100 * time.Millisecond):
return "", ""
}
}

func getParentProcessInfoSync() (name, cmdline string) {
ppid := os.Getppid()
if ppid <= 0 {
return "", ""
Expand Down
18 changes: 16 additions & 2 deletions pkg/analytics/posthog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,24 @@ func getTimezone() string {
}

func getGPUInfo() string {
type result struct {
out string
}
ch := make(chan result, 1)
go func() {
ch <- result{out: getGPUInfoSync()}
}()
select {
case r := <-ch:
return r.out
case <-time.After(100 * time.Millisecond):
return ""
}
}

func getGPUInfoSync() string {
out, err := exec.Command("nvidia-smi", "--query-gpu=name,memory.total,driver_version,count", "--format=csv,noheader,nounits").Output() // #nosec G204
if err != nil {
// nvidia-smi not available or no NVIDIA GPU
if runtime.GOOS == "darwin" {
return getAppleGPUInfo()
}
Expand All @@ -335,7 +350,6 @@ func getAppleGPUInfo() string {
if err != nil {
return ""
}
// Extract just the chipset/model lines
lines := strings.Split(string(out), "\n")
var gpuLines []string
for _, line := range lines {
Expand Down
Loading