Fix for deprecated getLiveSessionData#178
Draft
jjlawren wants to merge 1 commit intobretterer:mainfrom
Draft
Conversation
natekspencer
requested changes
Mar 29, 2026
Collaborator
natekspencer
left a comment
natekspencer
left a comment
There was a problem hiding this comment.
getLiveSessionData and getLiveSessionHistory are not compatible data models. As such, instead of remapping the underlying query for get_live_charging_session, it and the related tests should be renamed and validated appropriately.
Author
|
Fair enough. This appeared to restore functionality of the HA integration in my limited testing, but I unfortunately wasn't able to set up a full validation environment yet. Please feel free to close if this is the wrong approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying the suggested fixes discussed in bretterer/home-assistant-rivian#254. Tests also updated and passing.
Will require a fix in the HA custom component here by also replacing
getLiveSessionDatawithgetLiveSessionHistory.