move postgres tree store to spark-postgres crate#763
Merged
Conversation
JssDWt
force-pushed
the
jssdwt-share-postgres
branch
from
3f4c898 to
9aa15f3
Compare
JssDWt
requested review from
dangeross,
danielgranhao and
roeierez
and removed request for
roeierez
dangeross
reviewed
Mar 30, 2026
Comment on lines
-63
to
-68
| tokio-postgres = { workspace = true, optional = true } | ||
| tokio-postgres-rustls = { workspace = true, optional = true } | ||
| deadpool-postgres = { workspace = true, optional = true } | ||
| deadpool = { workspace = true, optional = true } |
Collaborator
There was a problem hiding this comment.
Do we need tokio-postgres and deadpool-postgres in this crate still?
Collaborator
There was a problem hiding this comment.
Ignore me. But maybe they could be re-exported?
Member
There was a problem hiding this comment.
I agree here. It would be nice also to see following PRs that move the pg token_store and storage to the spark_postgres as well.
roeierez
approved these changes
Mar 31, 2026
Member
roeierez
left a comment
roeierez
left a comment
There was a problem hiding this comment.
Other than Ross's comment about re-export LGTM
dangeross
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.