Skip to content

Include boltz regtest as submodule#774

Merged
danielgranhao merged 2 commits intomainfrom
daniel-replace-regtest-by-submodule
Mar 24, 2025
Merged

Include boltz regtest as submodule#774
danielgranhao merged 2 commits intomainfrom
daniel-replace-regtest-by-submodule

Conversation

@danielgranhao
Copy link
Copy Markdown
Contributor

@danielgranhao danielgranhao commented Mar 13, 2025

This PR replaces the existing regtest setup (that was a copy of boltz regtest) with using boltz regtest as a submodule. The motivation is letting us more easily keep up with changes to the boltz regtest setup. A short-term downside is that this will run some containers we don't need, but the solution is to propose upstream having those services be optionally disabled.

Copy link
Copy Markdown
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we add submodules we should also add notes (maybe in DEVELOPMENT/CONTRIBUTION) on how to clone the repo. Is it git clone --recurse-submodules --remote-submodules <repo-url>?

Comment thread regtest/README.md Outdated
@danielgranhao
Copy link
Copy Markdown
Contributor Author

danielgranhao commented Mar 14, 2025

I think if we add submodules we should also add notes (maybe in DEVELOPMENT/CONTRIBUTION) on how to clone the repo. Is it git clone --recurse-submodules --remote-submodules <repo-url>?

Given this submodule isn't essential, I think it's fine to add that note on the regtest README (added in b637db6). Let me know if you disagree.

Also, for context, I plan on improving regtest documentation on a later PR.

@danielgranhao danielgranhao requested a review from dangeross March 14, 2025 12:41
Comment thread regtest/.env
Comment on lines -20 to +4
RT_SYNC_IMAGE=hydrayse/data-sync:latest
RT_SYNC_IMAGE=danielgranhao/data-sync:latest
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a specific reason for this change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It updates the data sync service to a more recent version (to include breez/data-sync#4). Once breez/data-sync#18 is merged, we can finally set it to the proper value. I've just pinged @hydra-yse to see if we can do it now.

Copy link
Copy Markdown
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielgranhao danielgranhao merged commit 8645a6b into main Mar 24, 2025
10 of 13 checks passed
@danielgranhao danielgranhao deleted the daniel-replace-regtest-by-submodule branch March 24, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants