This repository was archived by the owner on May 5, 2024. It is now read-only.
Don't change the submitted filename#92
Open
wimverstuyf wants to merge 1 commit intobrandonsavage:masterfrom
Open
Don't change the submitted filename#92wimverstuyf wants to merge 1 commit intobrandonsavage:masterfrom
wimverstuyf wants to merge 1 commit intobrandonsavage:masterfrom
Conversation
Special characters are removed (mainly non-ANSI) which doesn't seem to be desirable when using non-English languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special characters were being removed (mainly non-ANSI) which doesn't seem to be desirable when using non-English languages.
E.g. the filename buffet-à-volonté.doc will be renamed to buffet--volont.doc
I couldn't find a proper way to make a filename "safe" across multiple languages so the best option seems to be to remove it altogether. I'm not sure why it had been added in the first place, it doesn't seem to be necessary.