Closed
Conversation
Contributor
Author
|
Woo I see you added the feature thank you! I will close the pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't realize this is also here so I'll leave the same comment I left on the enhancement request:
So I came up with something but I have no clue if its actually good. This took me a few days to figure out with a ton of trial and error. I have no clue if this is how dart likes to format its code. Also I couldn't get VSCode to properly load the project without updating the pubspec and the settings.json so I made changes to them on my side and removed them from the git tracking and I think that will keep it in line with your settings but I'm not sure if that was the correct choice tbh. I will submit a pull request for you to review. If it doesn't cut it its fine I honestly have no clue if this is memory safe or follows best practices.
Also some other things, I decided on the static table version for mine since I thought that would work better if the only point of change was the quantity and it should update automatically on saves