Avoid using locally-defined callbacks for yesno.
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since most of the callbacks do not rely on the local variables at all, there's little value in using locally defined callbacks over instance methods. This enables the ability to save and restore the state of the game even in the middle of a question (including the initial "WOULD YOU LIKE INSTRUCTIONS?") While this is not generally possible in the normal play, this change enables using this implementation of python-adventure in ephemeral environments where players bring their own state.
Owner
|
As this isn’t a currently active project for me, it might be some time before I can sit down and do a code review — and compare this new behavior to the original FORTRAN. But I’m happy to keep this PR open until my other projects offer some spare time to come back and look at this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most of the callbacks do not rely on the local variables at all,
there's little value in using locally defined callbacks over instance
methods.
This enables the ability to save and restore the state of the game even
in the middle of a question (including the initial "WOULD YOU LIKE
INSTRUCTIONS?")
While this is not generally possible in the normal play, this change
enables using this implementation of python-adventure in ephemeral
environments where players bring their own state.