Draft
Conversation
Rename/restructure CLI flags to improve UX without changing core behaviour: BaseArgs: - Remove --quiet/-q (BRAINTRUST_QUIET) and --no-input; quiet output is now the global default (set_quiet(true) in configure_output). - Add verbose: bool as #[arg(skip)] — subcommands set it at runtime; set up output messages are shown only when verbose is active. SetupArgs: - --no-mcp-skill → --no-skills + --no-mcp (orthogonal opt-outs) - Add --no-instrument (opt-out; instrument is the new default) - Add --tui / --background (replace --interactive / --quiet in wizard) - Add --language (repeatable), --interactive/-i, --verbose/-v at top level AgentsSetupArgs: - --agent (repeatable Vec) → --agent (single Option); drop AgentArg::All - --yes removed from CLI (#[arg(skip)]); programmatic callers still set yes:true - Add --no-workflow (conflicts with --workflow) AgentsMcpSetupArgs: - Same agents→agent and yes→skip treatment InstrumentSetupArgs: - --quiet → --background (run agent non-interactively, show spinner) - --interactive → --tui (run agent in interactive TUI mode) - --yes → #[arg(skip)] - Add skip_launch: bool (#[arg(skip)]) for future wizard use resolve_selected_agents: signature changes from &[AgentArg] to Option<AgentArg>; None auto-detects all installed agents as before. All call sites, struct literals in tests, and BaseArgs literals in auth/switch/traces/functions updated to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- `bt setup instrument --interactive` now accepted as alias for --tui - `bt setup instrument --quiet` now accepted as alias for --background - `bt setup --no-mcp-skill` now accepted as hidden alias for --no-skills --no-mcp - Explicit error when --json and --tui are both passed
move CLI coverage to integration tests
auth.rs: - Remove login_interactive (method-chooser) and login_interactive_api_key - Make login_interactive_oauth pub(crate) so setup can call it directly - Auth output tweaks: Warning→Info in maybe_warn_api_key_override, drop the else branch (no-profile case doesn't need a warning when an API key is used) - Add blank lines around the OAuth authorization URL for readability - Add org description hint before the org selection prompt - Add .report(false) to the OAuth callback manual-paste input - Add set_quiet(false) in run() so bt auth output is never silenced by the global quiet default (unless --json is active) - Add pub(crate) ensure_auth: credential recovery flow that falls back to OAuth when a stored profile's credentials are inaccessible - Add pub(crate) is_missing_credential_error helper used by ensure_auth setup/mod.rs: - Replace local ensure_auth with auth::ensure_auth - Remove local LoginContext import (no longer needed) - Add maybe_create_api_key_for_oauth: after an OAuth login, auto-create a permanent API key, expose it via BRAINTRUST_API_KEY, and print it once (the key is never retrievable again from the API) - Call maybe_create_api_key_for_oauth in run_setup_wizard after auth step Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bt does not need an api key but the agent executing the code with instrumentation needs it
also remove dead code
ViaDézo1er / cedric (viadezo1er)
force-pushed
the
cedric-better-dx-pr4
branch
from
1627dd5 to
da0a152
Compare
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
ViaDézo1er / cedric (viadezo1er)
force-pushed
the
cedric-better-dx-pr4
branch
from
da0a152 to
d639bbb
Compare
Asking to use auto instrumentation
not mentionning unsued languages when --language is passed or a language is detected
repeating url formatting information
added (and forgot to commit) a small test file to check if bt setup --no-instrument would complete without any prompt with the correct env variables. After re-reading it it's probably better to add it in a future PR.
ViaDézo1er / cedric (viadezo1er)
force-pushed
the
cedric-better-dx-pr4
branch
from
d639bbb to
fbb6fb4
Compare
ViaDézo1er / cedric (viadezo1er)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the commits are due to rebasing.
PR4 of #94