feat: Consistently include original in "Unexpected response" errors#392
Merged
brainlid merged 5 commits intobrainlid:mainfrom Feb 14, 2026
Merged
Conversation
3 tasks
Owner
|
Thanks @mweidner037! Sorry it took me so long to follow-up on this. I appreciate your contribution and work though! |
brainlid
added a commit
that referenced
this pull request
Feb 14, 2026
- repairs issue introduced in PR #392 - adds additional error catch for something in the shape of {:error, thing} and tracking the "original" error info on the LangChainError
brainlid
added a commit
that referenced
this pull request
Feb 14, 2026
- repairs issue introduced in PR #392 - adds additional error catch for something in the shape of {:error, thing} and tracking the "original" error info on the LangChainError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're encountering these while using ChatGoogleAI but with
original: nil. The PR addsoriginalin that case, as well as in the other Chat... classes at an analogous place.Note: There is a difference in the error messages returned in the "Unexpected response" case for streaming vs non-streaming, consistently across chat models. If you like, I can make them consistent with each other, in either direction.