Skip to content

fix string->int failure in bad id test#106

Merged
IgorTatarnikov merged 1 commit intomainfrom
update-test-for-pandas-3
Jan 26, 2026
Merged

fix string->int failure in bad id test#106
IgorTatarnikov merged 1 commit intomainfrom
update-test-for-pandas-3

Conversation

@alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Jan 26, 2026

Pandas now enforces "banning of upcasting in in-place setitem-like operations; see PDEP6 (GH 59007)" since release 3.0, which we were doing in this test.

I fixed this by, instead of pretending the string "BAD ID" is an int64, setting the bad id to the most negative value that we can represent with np.int64 (which is indeed a bad id for the Allen morphology neurons).

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.37%. Comparing base (18f7178) to head (b587719).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   72.37%   72.37%           
=======================================
  Files          10       10           
  Lines         724      724           
=======================================
  Hits          524      524           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IgorTatarnikov IgorTatarnikov merged commit 91976e4 into main Jan 26, 2026
23 checks passed
@IgorTatarnikov IgorTatarnikov deleted the update-test-for-pandas-3 branch January 26, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants