add require_variance to model_interface look_at signature#652
Open
benlonnqvist wants to merge 7 commits intobrain-score:masterfrom
Open
add require_variance to model_interface look_at signature#652benlonnqvist wants to merge 7 commits intobrain-score:masterfrom
benlonnqvist wants to merge 7 commits intobrain-score:masterfrom
Conversation
mschrimpf
approved these changes
Mar 18, 2024
Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com>
Contributor
|
Hi @benlonnqvist, is this PR still in progress? If not, should it be closed? Thanks for the contributions! |
Contributor
Author
|
Hi @deirdre-k, thanks for the message. This PR is technically still in progress and while PR #917 fixed the issue about being able to call microsaccades, the signature issue in model_interface / elsewhere still seems to be open. We could either:
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #651.
In addition, this PR adds traversal paths for
require_variancefor non-neural task models (Behavior, ProbabilitiesMapping, Temporal).