Group-based Splitting for Benchmarks + Batch-layer Evaluation + GPU Support #361
+943
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KartikP
force-pushed
the
epflneuroailab-changes
branch
from
ec07cd5 to
27f9d2e
Compare
KartikP
force-pushed
the
epflneuroailab-changes
branch
from
bb6ba01 to
b913b91
Compare
The new cross-validation kwargs (split_coord="story", kfold="group") change the ceiling from 0.2103 to 0.1446.
- blank2014: add story coord to predictions (needed for split_coord="story") - fedorenko2016: add sentence_id coord to predictions (needed for split_coord="sentence_id") - pereira2018: replace .coords check with try/except to handle xarray MultiIndex levels not appearing in .coords (xarray 2022.3.0 behavior) - pereira2018/test.py: update test_dummy_bad expected scores for new GroupKFold CV strategy (243: 0.0186->0.0, 384: 0.0334->0.0168) - linear_predictivity/test.py: update expected score (0.0283->0.0410)
mike-ferguson
added
the
submission_prepared
KartikP
removed
the
submission_prepared
mike-ferguson
added
the
submission_prepared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #356 but with other changes to get it to work with testing infrastructure.